Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Maintenance/improve public api ci job #2616

Merged
merged 19 commits into from
Nov 1, 2021
Merged

♻️ Maintenance/improve public api ci job #2616

merged 19 commits into from
Nov 1, 2021

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2021 •
edited by pcrespov
Loading

What do these changes do?

  • public-api CI job shall wait for simcore services to be ready before running tests
    • simcore_services_ready is a module fixture that checks healthcheck entrypoints until all selected core services are ready

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:api framework api, data schemas, label Nov 1, 2021
@sanderegg sanderegg added this to the Anti-PER milestone Nov 1, 2021
@sanderegg sanderegg self-assigned this Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021 •
edited
Loading

Codecov Report

Merging #2616 (7110a0f) into master (c7438fe) will decrease coverage by 5.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2616     +/-   ##
========================================
- Coverage    76.9%   71.5%   -5.5%     
========================================
  Files         631     631             
  Lines       24756   24756             
  Branches     2432    2432             
========================================
- Hits        19060   17712   -1348     
- Misses       5052    6474   +1422     
+ Partials      644     570     -74
Flag Coverage Δ
integrationtests ?
unittests 71.4% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_director_v2/utils/logging_utils.py 91.9% <100.0%> (ø)
...es/sidecar/src/simcore_service_sidecar/mpi_lock.py 29.6% <0.0%> (-70.4%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 32.6% <0.0%> (-67.4%) ⬇️
...simcore_service_webserver/computation_subscribe.py 30.0% <0.0%> (-62.5%) ⬇️
...imcore_service_webserver/exporter/export_import.py 34.1% <0.0%> (-61.0%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 25.0% <0.0%> (-57.4%) ⬇️
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-56.4%) ⬇️
...ore_service_director_v2/api/routes/computations.py 33.0% <0.0%> (-54.5%) ⬇️
...vice_webserver/exporter/formatters/formatter_v1.py 24.5% <0.0%> (-54.2%) ⬇️
...c/simcore_service_webserver/users_to_groups_api.py 46.1% <0.0%> (-53.9%) ⬇️
... and 72 more

@sanderegg sanderegg requested a review from odeimaiz November 1, 2021 10:45
odeimaiz
odeimaiz approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the maintenance/improve_public_api_ci_job branch from 882a698 to 310b09b Compare November 1, 2021 20:28
@sanderegg sanderegg merged commit c721f94 into ITISFoundation:master Nov 1, 2021
@sanderegg sanderegg deleted the maintenance/improve_public_api_ci_job branch November 1, 2021 21:56
@sanderegg sanderegg mentioned this pull request Nov 4, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeimaiz odeimaiz odeimaiz approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@mguidon mguidon Awaiting requested review from mguidon

@colinRawlings colinRawlings Awaiting requested review from colinRawlings

Assignees

@sanderegg sanderegg

Labels
a:api framework api, data schemas,
Projects
None yet
Milestone
Anti-PER
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderegg @pcrespov @odeimaiz